-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(empty-table-header): new rule to flag empty table headers #2811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together. It's a great start and just needs a few things.
test/integration/rules/aria-empty-table-header/aria-empty-table-header.html
Outdated
Show resolved
Hide resolved
test/integration/rules/aria-empty-table-header/aria-empty-table-header.html
Outdated
Show resolved
Hide resolved
995d043
to
7fd95fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Just a few more changes.
test/integration/rules/aria-empty-table-header/aria-empty-table-header.html
Outdated
Show resolved
Hide resolved
test/integration/rules/aria-empty-table-header/aria-empty-table-header.json
Outdated
Show resolved
Hide resolved
test/integration/rules/empty-table-header/empty-table-header.json
Outdated
Show resolved
Hide resolved
Oh yes, I believe that was before we switched to karma for our testing framework. Develop now just watches and re-runs the specific test file associated with the script. To run the full tests you do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you for the contribution!
Reviewed for security. |
<< Describe the changes >>
New rule created for #2604
For initial review only!
Closes issue: